Speech to speech: Mute functionality#5688
Open
pranavjoshi001 wants to merge 9 commits intomicrosoft:mainfrom
Open
Speech to speech: Mute functionality#5688pranavjoshi001 wants to merge 9 commits intomicrosoft:mainfrom
pranavjoshi001 wants to merge 9 commits intomicrosoft:mainfrom
Conversation
…BotFramework-WebChat into feature/s2s-mute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This PR adds mute/unmute functionality for the Speech-to-Speech (S2S) feature as core API only, without UI changes. When muted, the microphone is turned off (browser indicator disappears) but silent audio chunks continue to be sent to keep the server connection alive. This prevents connection timeouts while allowing consumers to implement their own mute UI.
Design
The mute functionality works at multiple levels:
AudioWorklet Level:
MUTEandUNMUTEcommandsuseRecorder Hook (
useRecorder.ts):mute()function that:MUTEcommand to the workletunmute()function that:UNMUTEcommand to the workletgetUserMediaVoiceRecorderBridge (
VoiceRecorderBridge.tsx):mutefunction to the voice state machinemuted, callsmute()and stores theunmutefunctionlistening, calls the storedunmutefunctionRedux Actions & Hooks:
muteVoiceRecordingandunmuteVoiceRecordingRedux actionsuseMuteVoiceanduseUnmuteVoicehooks for consumersSpecific Changes
MUTEandUNMUTEcommand handling in AudioWorklet processor to generate silent chunks when mutedmutefunction touseRecorder.tshook that disconnects audio and stops MediaStream while continuing to send silent chunksVoiceRecorderBridge.tsxto handle mute/unmute based on voice state changesmuteVoiceRecording.tsandunmuteVoiceRecording.tsRedux actionsvoiceActivity.tsreducer to handleVOICE_MUTE_RECORDINGandVOICE_UNMUTE_RECORDINGactionsuseMuteVoice.tsanduseUnmuteVoice.tshooks and exported them from API, component, and bundle packagesuseRecorder.spec.tsxCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed